RHSTOR-6347: Enable recipe-based DR enrollment for discovered applications #1589
Conversation
|
@GowthamShanmugam: This pull request references RHSTOR-6347 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
GowthamShanmugam
force-pushed
the
RHSTOR-6347
branch
from
c079f30
to
536c3a3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
GowthamShanmugam
force-pushed
the
RHSTOR-6347
branch
from
536c3a3
to
f677a51
Compare
…tions Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
GowthamShanmugam
force-pushed
the
RHSTOR-6347
branch
from
f677a51
to
4384c78
Compare
|
|
||
| const prevLoader = React.useRef<PromiseComponent>(null); | ||
|
|
||
| const setComponent = React.useCallback( | ||
| (value) => { | ||
| Component.current = value; | ||
| setLoaded(true); | ||
| if (mounted.current) { | ||
| setLoaded(true); |
There was a problem hiding this comment.
To fix unit test case waring, React state update on an unmounted component
There was a problem hiding this comment.
Just curious: there are other state variables too, why jest is complaining only about this one in particular ??
Also, why doesn't it do so for other components that we have in this repo, why only this ??
There was a problem hiding this comment.
are we sure there isn't some other reason for this warning ??
| @@ -295,23 +294,23 @@ export const PVCDetailsWizardContent: React.FC<PVCDetailsWizardContentProps> = | |||
| return ( | |||
| <Form> | |||
| <FormGroup> | |||
| <Text> | |||
| <span> | |||
There was a problem hiding this comment.
To fix unit test case waring, div cannot appear as a descendant of p
GowthamShanmugam
force-pushed
the
RHSTOR-6347
branch
from
4384c78
to
761ed9b
Compare
|
Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
GowthamShanmugam
force-pushed
the
RHSTOR-6347
branch
from
761ed9b
to
74d61f1
Compare
| @@ -152,7 +156,7 @@ export const SelectableTable: SelectableTableProps = < | |||
| onSelect: onSelect, | |||
| isSelected: isRowSelected(getUID(row), selectedRows), | |||
| isDisabled: | |||
| !isRowSelectable?.(row) || | |||
| (!!isRowSelectable && !isRowSelectable?.(row)) || | |||
There was a problem hiding this comment.
this is not needed... !isRowSelectable?.(row) syntax will only execute when function exists, else not...
| (!!isRowSelectable && !isRowSelectable?.(row)) || | |
| (!isRowSelectable?.(row) || |
There was a problem hiding this comment.
original line was correct...
| @@ -47,13 +47,18 @@ const useAsynchronousLoading: UseAsynchronousLoading = ( | |||
| const Component = React.useRef<React.ComponentType>(null); | |||
| const [loadingStarted, setLoadingStarted] = React.useState(false); | |||
| const [loaded, setLoaded] = React.useState(false); | |||
| // Mount status for safty state updates | |||
There was a problem hiding this comment.
| // Mount status for safty state updates | |
| // Mount status for safely state updates |
There was a problem hiding this comment.
we can remove the comment as well... it's kind of self-explanatory from variable name itself...
No description provided.